Do not retry failing requests with status code 401 #408
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hodnebo
requested review from
rcypher-databricks,
yunbodeng-db,
andrefurlan-db,
jackyhu-db,
benc-db and
kravets-levko
as code owners
|
Hi @Hodnebo! Thank you for this fix! Can you please resolve conflicts so I can merge it? |
- Raises NonRecoverableNetworkError when request results in 401 status code Signed-off-by: Tor Hødnebø <[email protected]> Signed-off-by: Tor Hødnebø <[email protected]>
Signed-off-by: Tor Hødnebø <[email protected]> Signed-off-by: Tor Hødnebø <[email protected]>
Thanks for the quick review, it should hopefully be in order now |
kravets-levko
approved these changes
Jul 3, 2024
|
Thank you @Hodnebo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds another check to
should_retry()for requests resulting in status code401.Very similar to #373, but happens when token is malformed, rather than being expired/invalid.
Fixes #407